Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14219 )
Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14219/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/14219/2/src/kudu/client/client-test.cc@5626 PS2, Line 5626: ASSERT_EQ(x, y); > nit: whoops, I didn't notice it in prior revision, but a space is missing b Done http://gerrit.cloudera.org:8080/#/c/14219/2/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: http://gerrit.cloudera.org:8080/#/c/14219/2/src/kudu/client/scan_batch.h@165 PS2, Line 165: /// Overloaded operator -> to support pointer trait : /// for access via const_iterato > I think it's worth keeping this for doxigen-generated doc (i.e. have triple Done -- To view, visit http://gerrit.cloudera.org:8080/14219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ddd99073d6a93337c184bee8b930cabeeda145 Gerrit-Change-Number: 14219 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 13 Sep 2019 21:27:57 +0000 Gerrit-HasComments: Yes
