Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14219 )
Change subject: KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator ...................................................................... KUDU-1561 Implemented operator->() in KuduScanBatch::const_iterator operator->() requires returning pointer or object which overloads access via pointer operator (operator->() again). Since KuduScanBatch::const_iterator does to keep current KuduScanBatch::RowPtr, we cannot return pointer to it in operator ->. Instead, we return KuduScanBatch::RowPtr which implements pointer trait (operator->). Change-Id: Ib5ddd99073d6a93337c184bee8b930cabeeda145 Reviewed-on: http://gerrit.cloudera.org:8080/14219 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/client/client-test.cc M src/kudu/client/scan_batch.h 2 files changed, 28 insertions(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib5ddd99073d6a93337c184bee8b930cabeeda145 Gerrit-Change-Number: 14219 Gerrit-PatchSet: 4 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com>
