Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14227 )
Change subject: [mini_cluster] introduce 'builtin' clock source ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/mini-cluster/external_mini_cluster.h@190 PS2, Line 190: // Number of NTP servers to start as part of the cluster, gated by the : // 'use_builtin_ntp' property. The servers are used as reference NTP servers : // for the built-in NTP client: it uses them to synchronize its internal : // clock. This setting is effective (i.e. the specified number of NTP servers : // is started) only if the 'use_builtin_ntp' property is set to 'true'. : // : // Default: 1 : int num_ntp_servers; : : // Whether Kudu masters and tablet servers are using the built-in NTP client. : // : // Default: false : int use_builtin_ntp; How about you drop use_builtin_ntp and use num_ntp_servers=0 to mean "no built-in NTP"? Or is it valuable to launch a bunch of NTP servers _without_ the built-in client? http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/mini-cluster/external_mini_cluster.cc@245 PS2, Line 245: // Collect and keep alive the set of sockets bound with SO_REUSEPORT option As I mentioned in the other patch, I think it'd be better to patch chrony to support ephemeral port binding and then use the lsof approach to figure out where it landed. This is similar to how we manage the KDC and will be safer on non-UNIQUE_LOOPBACK environments. -- To view, visit http://gerrit.cloudera.org:8080/14227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c334ae6fa1fb12b033de7f8e8584b8dd3aa2d32 Gerrit-Change-Number: 14227 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 14 Sep 2019 00:30:05 +0000 Gerrit-HasComments: Yes
