Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14227 )
Change subject: [mini_cluster] introduce 'builtin' clock source ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/integration-tests/master_migration-itest.cc File src/kudu/integration-tests/master_migration-itest.cc: http://gerrit.cloudera.org:8080/#/c/14227/2/src/kudu/integration-tests/master_migration-itest.cc@202 PS2, Line 202: // unique_ptr wrapper by calling 'std::unique_ptr::reset()'. > I expected it to do so, yes. But it doesn't work that way. Yeah, separate patch makes sense. Worth also thinking about how much that'd increase test running time. The KDC isn't that slow, but HMS/Sentry are. -- To view, visit http://gerrit.cloudera.org:8080/14227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c334ae6fa1fb12b033de7f8e8584b8dd3aa2d32 Gerrit-Change-Number: 14227 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 30 Sep 2019 21:36:19 +0000 Gerrit-HasComments: Yes
