Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14154 )
Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14154/2/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14154/2/src/kudu/rebalance/rebalancer.h@205 PS2, Line 205: a specific tabl > nit: document whether it's possible to specify 'nullptr' as an argument whe Done http://gerrit.cloudera.org:8080/#/c/14154/2/src/kudu/rebalance/rebalancer.cc File src/kudu/rebalance/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14154/2/src/kudu/rebalance/rebalancer.cc@157 PS2, Line 157: // No healthy tablet of s > This seems to be the only place where the output parameter is assigned. Do Done http://gerrit.cloudera.org:8080/#/c/14154/2/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/14154/2/src/kudu/tools/rebalancer_tool.cc@951 PS2, Line 951: for (const auto& s : raw_info.tablet_summaries) { : int num_voters = 0; : for (const auto& rs : s.replicas) { : if (rs.is_voter) { : ++num_voters; : } : } : const auto rf = FindOrDie(replication_factors_by_table, s.table_id); : EmplaceOrDie(&extra_info_by_tablet_id, : s.id, TabletExtraInfo{rf, num_voters}); : } : } > Moving the replicas from the healthy ignored tservers and moving the replic Done -- To view, visit http://gerrit.cloudera.org:8080/14154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86cfb740030946c13db1a9ca63d241f4907d6c89 Gerrit-Change-Number: 14154 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Sat, 14 Sep 2019 00:55:08 +0000 Gerrit-HasComments: Yes
