Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14154 )
Change subject: KUDU-2914: Rebalance tool support moving replicas from some specific tablet servers ...................................................................... Patch Set 4: (13 comments) http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/rebalance/rebalancer.h File src/kudu/rebalance/rebalancer.h: http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/rebalance/rebalancer.h@72 PS4, Line 72: // If not empty, specified tablet servers(including their health state nit: missing space http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/rebalance/rebalancer.h@101 PS4, Line 101: run running http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/rebalance/rebalancer.h@202 PS4, Line 202: with the result status of Status::OK() This part is no longer relevant once the return type changed from Status to void, right? http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool-test.cc@239 PS4, Line 239: Security Safety? http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool-test.cc@245 PS4, Line 245: TEST_P(RebalanceStartSecurityTest, TooManyIgnoredTservers) { I think it's also necessary to add a scenario when the rebalancer tool actually moves replicas from the ignored tservers. Sub-scenarios should include cases when some of ignored tservers are up and running, while others are shut down. http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool-test.cc@278 PS4, Line 278: err_msg_pattern nit: this constant is used only once; maybe replace it's usage with the string literal as is at line 279? http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool-test.cc@299 PS4, Line 299: nit: an extra line http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool.h File src/kudu/tools/rebalancer_tool.h: http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool.h@327 PS4, Line 327: of nit: about http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool.h@346 PS4, Line 346: ignored_tservers nit: ignored That would be easier to read. http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/rebalancer_tool.cc@1014 PS4, Line 1014: if (elem != move.to && !ContainsKey(cluster_info.healthy_ignored_tservers, elem)) { : LOG(INFO) << Substitute("choose destination server: $0",elem); : move.to = elem; : break; : } How is it guaranteed that the amended move doesn't make the cluster even more imbalanced than it was before this move? Please add a comment about that. http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/tool_action_cluster.cc@130 PS4, Line 130: moves move http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/tool_action_cluster.cc@130 PS4, Line 130: 'ignored_tservers' servers http://gerrit.cloudera.org:8080/#/c/14154/4/src/kudu/tools/tool_action_cluster.cc@132 PS4, Line 132: This setting only works when 'ignored_tservers' are specified. How about: This setting is effective only if the '--ignored_tservers' flag is specified as well. -- To view, visit http://gerrit.cloudera.org:8080/14154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86cfb740030946c13db1a9ca63d241f4907d6c89 Gerrit-Change-Number: 14154 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 30 Sep 2019 07:56:59 +0000 Gerrit-HasComments: Yes
