Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 )
Change subject: tools: don't open block manager when dumping UUID ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14243/2/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: PS2: > Could you adjust the function and/or class comments so that it's clearer wh I only singled out Open() and CreateInitialFileSystemLayout(). Anything else seems like a bit too much implementation detail. http://gerrit.cloudera.org:8080/#/c/14243/2/src/kudu/fs/fs_manager.h@156 PS2, Line 156: // Returns an error if the file system is already initialized. : Status CreateInitialFileSystemLayout( : boost::optional<std::string> uuid = boost::none); > Not clear what FsManager functions are safe to call after calling this and Done -- To view, visit http://gerrit.cloudera.org:8080/14243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acf3b08fc13c169a52d4cfe847efd62bd30cc0a Gerrit-Change-Number: 14243 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Sep 2019 21:42:34 +0000 Gerrit-HasComments: Yes
