Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14243 )
Change subject: tools: don't open block manager when dumping UUID ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14243/2/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: PS2: > I only singled out Open() and CreateInitialFileSystemLayout(). Anything els I don't think this is nearly enough: - Do I need to call Init() before calling Open() or CreateInitialFileSystemLayout()? Or do those functions do that for me? - Likewise, do I need to call LoadAndVerifyMetadataFiles() before either of those other two? Do I need to call Init() first? Taking a step back, FsManager now has four public functions whose names vaguely hint at affecting object lifecycle. When we only had two, the only ambiguity was whether to call Open after calling Create (it was somewhat obvious that Create didn't make sense after Open). Now there's a lot more ambiguity, especially with Init(), which sounds like it's always necessary. -- To view, visit http://gerrit.cloudera.org:8080/14243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0acf3b08fc13c169a52d4cfe847efd62bd30cc0a Gerrit-Change-Number: 14243 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Sep 2019 21:48:45 +0000 Gerrit-HasComments: Yes
