Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14259 )
Change subject: KUDU-2946: avoid ServicePool inc/dec in Messenger::QueueInboundCall ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14259/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/14259/1/src/kudu/rpc/messenger.cc@375 PS1, Line 375: shared_lock<rw_spinlock> guard(lock_.get_lock()); > nit: could you also add a comment explaining that this locking is longer th +1 -- To view, visit http://gerrit.cloudera.org:8080/14259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id759617dcb13a2533e9ce071880c43678b700d25 Gerrit-Change-Number: 14259 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Sep 2019 23:41:30 +0000 Gerrit-HasComments: Yes
