Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14259 )
Change subject: KUDU-2946: avoid ServicePool inc/dec in Messenger::QueueInboundCall ...................................................................... KUDU-2946: avoid ServicePool inc/dec in Messenger::QueueInboundCall Before commit 0ecc2c771, this function took the Messenger lock for what seemed like longer than necessary. To reduce the size of the critical section, we had to explicitly take a ServicePool ref, then release it at the end of the function. This turned out to have unintended side effects: it's possible for the release to drop the last ref and destroy the ServicePool. The problem with this is that QueueInboundCall is called by the reactor thread and destroying the ServicePool is a blocking operation. Rather than untangle the morass of _how_ the reactor thread ended up with the last ServicePool ref, let's just revert this portion of that commit. Change-Id: Id759617dcb13a2533e9ce071880c43678b700d25 Reviewed-on: http://gerrit.cloudera.org:8080/14259 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/rpc/messenger.cc 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id759617dcb13a2533e9ce071880c43678b700d25 Gerrit-Change-Number: 14259 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
