YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14273 )
Change subject: add a tool to create table ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14273/5/src/kudu/util/jsonreader.h File src/kudu/util/jsonreader.h: http://gerrit.cloudera.org:8080/#/c/14273/5/src/kudu/util/jsonreader.h@95 PS5, Line 95: // Judge the field whether exist, return true if exist, if not return false > How about "Returns true if the field exists, false otherwise"? Yeah, My English is pool... http://gerrit.cloudera.org:8080/#/c/14273/5/src/kudu/util/jsonreader.h@97 PS5, Line 97: const char* field); > Nit: fix indentation (should line up with 'const rapidjson...' from the lin OK -- To view, visit http://gerrit.cloudera.org:8080/14273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacd9ae64dc07e3da6efe840e4bbcfaf3df0ecdc7 Gerrit-Change-Number: 14273 Gerrit-PatchSet: 5 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2019 03:20:35 +0000 Gerrit-HasComments: Yes
