Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14273 )
Change subject: add a tool to create table ...................................................................... Patch Set 6: > The PB message is from common.proto, the column type is enum-type, I don't > know if it fits. We shouldn't expose PB messages from common.proto via CLI tools; those are server-side and should be able to evolve independently of the tooling. Let's add new message definitions to tool.proto instead. > In the JSON object the column type defined as a integer, maybe not friendly. Yeah I think we should switch this to an enum to make it more user-friendly. -- To view, visit http://gerrit.cloudera.org:8080/14273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacd9ae64dc07e3da6efe840e4bbcfaf3df0ecdc7 Gerrit-Change-Number: 14273 Gerrit-PatchSet: 6 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2019 17:18:11 +0000 Gerrit-HasComments: No
