Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14292 )
Change subject: [tools] Add get table statistics for CLI tools ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14292/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/14292/1/src/kudu/client/client.h@977 PS1, Line 977: std::string to_string() const; ToString() is more idiomatic in Kudu (see KuduScanner). http://gerrit.cloudera.org:8080/#/c/14292/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14292/1/src/kudu/tools/tool_action_table.cc@870 PS1, Line 870: { Nit: what's the extra scope for? Not like table_statistics does anything fancy when it goes out of scope. http://gerrit.cloudera.org:8080/#/c/14292/1/src/kudu/tools/tool_action_table.cc@885 PS1, Line 885: unique_ptr<Action> analyze_table = : ActionBuilder("analyze", &AnalyzeTable) : .Description("Analyze a table") : .AddRequiredParameter({ kMasterAddressesArg, kMasterAddressesArgDesc }) : .AddRequiredParameter({ kTableNameArg, "Name of the table to analyze" }) : .Build(); I think "analyze" promises much more than what this actually does. How about call the action get_statistics, and put it under "kudu table statistics"? -- To view, visit http://gerrit.cloudera.org:8080/14292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie946a29ca5731ef72270d4ef870dd5919edaf869 Gerrit-Change-Number: 14292 Gerrit-PatchSet: 1 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Sep 2019 17:07:10 +0000 Gerrit-HasComments: Yes
