ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14292 )
Change subject: [tools] Add get table statistics for CLI tools ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14292/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14292/2/src/kudu/tools/tool_action_table.cc@1081 PS2, Line 1081: ActionBuilder("statistics", &GetTableStatistics) > I was thinking you could call this just "statistics" to keep it short, and Make sense. "Get/Set" are always used as pair, use "get" will lead to people think there was "set". Here we shouldn't set statistics so we can omit get :) -- To view, visit http://gerrit.cloudera.org:8080/14292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie946a29ca5731ef72270d4ef870dd5919edaf869 Gerrit-Change-Number: 14292 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2019 05:52:06 +0000 Gerrit-HasComments: Yes
