Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14355 )
Change subject: [mini_cluster] fix accessing wildcard-bound NTP server ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14355/1/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/14355/1/src/kudu/mini-cluster/external_mini_cluster.cc@172 PS1, Line 172: ntp_endpoints.emplace_back( Would it be clearer if MiniChronyd had an address() method like MiniHms, and the transformation would happen there? Seems a better separation of concerns: options() clearly indicates the input to chronyd, while address() (and perhaps in the future other methods) reflect the running state of chronyd. -- To view, visit http://gerrit.cloudera.org:8080/14355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62a326a47160aefe9a5806162e6df7c4d6060ba5 Gerrit-Change-Number: 14355 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Oct 2019 00:01:15 +0000 Gerrit-HasComments: Yes
