Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14355 )
Change subject: [mini_chronyd] introduce MiniChronyd::address() ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14355/2/src/kudu/clock/test/mini_chronyd.cc File src/kudu/clock/test/mini_chronyd.cc: http://gerrit.cloudera.org:8080/#/c/14355/2/src/kudu/clock/test/mini_chronyd.cc@176 PS2, Line 176: HostPort addr(options_.bindaddress == kWildcardIpAddr ? kLoopbackIpAddr : : options_.bindaddress, : options_.port); : return addr; Nit: could combine. -- To view, visit http://gerrit.cloudera.org:8080/14355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62a326a47160aefe9a5806162e6df7c4d6060ba5 Gerrit-Change-Number: 14355 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Oct 2019 06:27:42 +0000 Gerrit-HasComments: Yes
