Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2 ...................................................................... Patch Set 27: (1 comment) http://gerrit.cloudera.org:8080/#/c/13869/27/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/13869/27/src/kudu/client/schema.cc@276 PS27, Line 276: data_->length = length; > It will result in an InvalidArgument as per https://gerrit.cloudera.org/c/1 If we don't have it covered by a test, I would add one: that would not hurt, I think. The idea is to: * make sure that the error condition is handled * catch a regression, if any, when the related code changes * be explicit where we expect an error to surface -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 27 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2019 15:01:18 +0000 Gerrit-HasComments: Yes
