Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13869 )

Change subject: KUDU-1938 Add C++ client support for VARCHAR pt 2
......................................................................


Patch Set 25:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13869/21/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/13869/21/src/kudu/client/schema.h@99
PS21, Line 99:   ///@{
> yep, somehow I messed this up, fixed
turns out we need this after all, although it can be private, but 
KuduColumnStorageAttributes needed to make some new friends



--
To view, visit http://gerrit.cloudera.org:8080/13869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8
Gerrit-Change-Number: 13869
Gerrit-PatchSet: 25
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:57:48 +0000
Gerrit-HasComments: Yes

Reply via email to