Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 11: > I can't understand the failure in the jenkins. In `IWYU.log` no > error message found. I suspect there is something wrong with the > code version. Right, it's not an error message, but IWYU says it wants you to fix include directives in src/kudu/tools/tool_action_table.cc Basically, you need to update your code as it says and submit the new version of the patch for review. You can save the following into the file (say, /tmp/iwyu.diff) and then apply it from the root of your kudu workspace: patch -p0 < /tmp/iwyu.diff ##### snip ##### --- src/kudu/tools/tool_action_table.cc +++ src/kudu/tools/tool_action_table.cc @@ -17,7 +17,6 @@ #include <algorithm> #include <cstdint> - #include <iostream> #include <map> #include <memory> @@ -32,6 +31,8 @@ #include <gflags/gflags.h> #include <gflags/gflags_declare.h> #include <glog/logging.h> +#include <google/protobuf/stubs/status.h> +#include <google/protobuf/stubs/stringpiece.h> #include <google/protobuf/util/json_util.h> #include <rapidjson/document.h> ##### snip ##### -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 11 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Sat, 12 Oct 2019 02:29:42 +0000 Gerrit-HasComments: No
