YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 15: (2 comments) I modify the code according to the comments. Setting default value for DECIMAL type is not supported. http://gerrit.cloudera.org:8080/#/c/14306/15/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/15/src/kudu/tools/tool_action_table.cc@752 PS15, Line 752: */ Here I'm not sure if decimal type supports setting default value. And no similar example has been found. I try to use `KuduValue::FromDecimal`, I split the value string with `.`, first value used as precision, second used as scale, but it doesn't look right. http://gerrit.cloudera.org:8080/#/c/14306/15/src/kudu/tools/tool_action_table.cc@1290 PS15, Line 1290: "\"3600\"}},\"num_replicas\":3}'.") Here I just list an example, maybe too simple. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 15 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2019 10:06:51 +0000 Gerrit-HasComments: Yes
