Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14420 )
Change subject: KUDU-1620: Update consensus peer proxies when a network error occurs ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14420/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/14420/1/src/kudu/consensus/consensus_peers.cc@518 PS1, Line 518: consensus_proxy_(std::move(DCHECK_NOTNULL(consensus_proxy))) { > BTW, another option is to address KUDU-75 directly. Not sure if you've look Done. I have some concerns about KUDU-75 . If the RPC proxy do the DNS resolution, will all RPC calls become more time consuming and the exting DNS cache become useless? If we add a TTL cache for ip addresses in proxy, we have to wait the entry expired or another refresh method should be added? http://gerrit.cloudera.org:8080/#/c/14420/1/src/kudu/consensus/consensus_peers.cc@524 PS1, Line 524: const rpc::ResponseCallback& callback) { > What are the synchronization requirements around PeerProxy? Could multiple Done -- To view, visit http://gerrit.cloudera.org:8080/14420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied476d302b1d9489a030847b5da74d60d0c1d8e9 Gerrit-Change-Number: 14420 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2019 12:30:04 +0000 Gerrit-HasComments: Yes
