Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14420 )
Change subject: KUDU-1620: Update consensus peer proxies when a network error occurs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14420/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/14420/1/src/kudu/consensus/consensus_peers.cc@518 PS1, Line 518: consensus_proxy_(std::move(DCHECK_NOTNULL(consensus_proxy))) { > Done. RPC calls wouldn't need to be more time consuming per se. Ideally the very first RPC call would do the DNS resolution and then store the resulting Sockaddr in the Proxy. Only on errors (or maybe just network errors) would DNS resolution be retried. We'd definitely want the proxies to use the DNS cache. We could plumb it into them via the Messenger, or separately. The default TTL is pretty short (15s) so I don't think we'd need an explicit way to flush the cache. -- To view, visit http://gerrit.cloudera.org:8080/14420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied476d302b1d9489a030847b5da74d60d0c1d8e9 Gerrit-Change-Number: 14420 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2019 16:42:15 +0000 Gerrit-HasComments: Yes
