Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 )
Change subject: KUDU-2971 p1: add subprocess module ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14425/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14425/2//COMMIT_MSG@8 PS2, Line 8: : This commit separates a facility class that support sending and : receiving messages with a subprocess via protobuf-based protocol over : stdin/stdout out from kudu tools module and moves it to the subprocess : module. nit: this sentence is a bit long to follow. Maybe: Utility classes exist that allow for IPC over stdin/stdout via protobuf and JSON-encoded protobuf. This commit moves those classes into their own directory so it can be reused by other subprocesses. http://gerrit.cloudera.org:8080/#/c/14425/2//COMMIT_MSG@13 PS2, Line 13: : Following commits can then extend it to support concurrent communications : with subprocess. nit: maybe mention that this patch has no functional changes. http://gerrit.cloudera.org:8080/#/c/14425/2/src/kudu/subprocess/subprocess_protocol.h File src/kudu/subprocess/subprocess_protocol.h: http://gerrit.cloudera.org:8080/#/c/14425/2/src/kudu/subprocess/subprocess_protocol.h@40 PS2, Line 40: // Each message is serialized into a protobuf-like JSON representation : // terminated with a newline character. : JSON, > Same as with the Java-side stuff, why is it useful to send JSON over the su Nevermind, I wrote this after not looking through all the files and realizing this is just moving stuff around. -- To view, visit http://gerrit.cloudera.org:8080/14425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If73e27772e1897a04f04229c4906a24c61e361f2 Gerrit-Change-Number: 14425 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 15 Oct 2019 02:10:36 +0000 Gerrit-HasComments: Yes
