Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 )
Change subject: KUDU-2971 p1: add subprocess module ...................................................................... Patch Set 3: (3 comments) I added a few comments to supbprocess_protocol.cc - I know this is refactored from tool_action_common.cc which was written by Adar, so maybe he could chime in on these? http://gerrit.cloudera.org:8080/#/c/14425/3/src/kudu/subprocess/subprocess_protocol.cc File src/kudu/subprocess/subprocess_protocol.cc: http://gerrit.cloudera.org:8080/#/c/14425/3/src/kudu/subprocess/subprocess_protocol.cc@45 PS3, Line 45: kMaxMessageBytes shouldn't this be a flag instead? RPC max message size is 50 MB by default and we've seen cases when it had to be increased. http://gerrit.cloudera.org:8080/#/c/14425/3/src/kudu/subprocess/subprocess_protocol.cc@97 PS3, Line 97: // Read four bytes of size (big-endian). isn't this little-endian? gutil/endian.h says " // Functions to do unaligned loads and stores in little-endian order." above Load32 and Store32. On the other hand they're in a class called BigEndian. In any case, it seems these functions only call reinterpret_cast in a macro. Maybe FromHost32 and ToHost32 could be used instead? Mini cluster from Java works though, so I guess it's not a problem. http://gerrit.cloudera.org:8080/#/c/14425/3/src/kudu/subprocess/subprocess_protocol.cc@120 PS3, Line 120: default: LOG(FATAL) << "Unknown mode"; do we need to crash the server if an unknown serialization mode is used? also, this is an enum class, do we need a default case? -- To view, visit http://gerrit.cloudera.org:8080/14425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If73e27772e1897a04f04229c4906a24c61e361f2 Gerrit-Change-Number: 14425 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 15 Nov 2019 13:14:47 +0000 Gerrit-HasComments: Yes
