Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14427 )
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) ...................................................................... Patch Set 5: Code-Review+1 (1 comment) When Attila did the VARCHAR/CHAR work, he prototyped the Impala side changes before merging the Kudu-side changes. This turned out to be a very good idea given how much difficulty he had with CHAR in Impala. So while I think this is ready to be merged, I'm gonna give a +1 and not a +2 until you've had a chance to modify Impala to use this and test that it works. You'll probably need the Java client change for that to work as Impala uses both the C++ and Java clients. Changes for the other integrations (Python, Spark, Hive, Nifi, etc.) are simpler and can be handled after merging the core stuff. http://gerrit.cloudera.org:8080/#/c/14427/5/src/kudu/common/types.cc File src/kudu/common/types.cc: http://gerrit.cloudera.org:8080/#/c/14427/5/src/kudu/common/types.cc@117 PS5, Line 117: constexpr static const char* kDateFormat = "%F"; // the ISO 8601 date format : static constexpr time_t kSecondsInDay = 24 * 60 * 60; adar@adar-Precision-5520:~/Source/kudu$ git grep "static constexpr" | wc -l 120 adar@adar-Precision-5520:~/Source/kudu$ git grep "constexpr static" | wc -l 4 adar@adar-Precision-5520:~/Source/kudu$ git grep "static const" | wc -l 917 adar@adar-Precision-5520:~/Source/kudu$ git grep "const static" | wc -l 0 So kDateFormat should be "static constexpr ..." -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 5 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2019 04:06:18 +0000 Gerrit-HasComments: Yes
