Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14427 )
Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client) ...................................................................... Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14427/5/src/kudu/common/types.cc File src/kudu/common/types.cc: http://gerrit.cloudera.org:8080/#/c/14427/5/src/kudu/common/types.cc@117 PS5, Line 117: void DataTypeTraits<DATE>::AppendDebugStringForValue(const void* val, string* str) { : constexpr static const char* kDateFormat = "%F"; // t > adar@adar-Precision-5520:~/Source/kudu$ git grep "static constexpr" | wc -l Looks like you missed this one. -- To view, visit http://gerrit.cloudera.org:8080/14427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986 Gerrit-Change-Number: 14427 Gerrit-PatchSet: 6 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2019 03:08:28 +0000 Gerrit-HasComments: Yes
