YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/14306/21/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/21/src/kudu/tools/tool_action_table.cc@937 PS21, Line 937: return Status::InvalidArgument(Substitute( > From the PB guide, about enums: I'm sorry, I made a mistake. If the integer value of enum is invalid, the option field will be ignored during parsing the JSON object to PB. Not setting a default value. In the test, if the encoding type value is set to 200, anyway the table can be built successfully. If value in string format is invalid, error will be reported in parsing JSON object. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 21 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2019 03:38:56 +0000 Gerrit-HasComments: Yes
