YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/14306/22/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/22/src/kudu/tools/tool_action_table.cc@1095 PS22, Line 1095: // test code end I add a test here. CreateTablePB is defined as: message CreateTablePB { enum EncodingType { UNKNOWN_ENCODING = 0; AUTO_ENCODING = 1; } optional EncodingType type = 1; } run the test: $ ./bin/kudu table create 1.1.1.1 {} directly output:0 $ ./bin/kudu table create 1.1.1.1 {type:0} type value: 0 directly output:0 $ ./bin/kudu table create 1.1.1.1 {type:1} type value: 1 directly output:1 $ ./bin/kudu table create 1.1.1.1 {type:2} directly output:0 At last case no error reported. So the empty object and the invalid value have the same result. I have not found the reason, it's kind of like this problem: https://groups.google.com/forum/#!msg/protobuf/wIeWEUFSfqg/CpcN3T4SAQAJ -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 22 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2019 06:26:34 +0000 Gerrit-HasComments: Yes
