Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 )
Change subject: [subprocess] KUDU-2791 p2: add basic protobuf msg ...................................................................... Patch Set 1: (1 comment) Not really sure why this is its own patch. Seems like it should at least include a test or something. http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto File src/kudu/subprocess/subprocess.proto: http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto@34 PS1, Line 34: // The request. The oneof approach works for the control shell, but I wonder if we can do better here. Some ideas to explore: - Could we repurpose the RPC "service" infrastructure without dragging in the socket-based transport? - If the RPC stuff doesn't pan out, what about Protobuf Any support? https://developers.google.com/protocol-buffers/docs/proto3#any -- To view, visit http://gerrit.cloudera.org:8080/14426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954 Gerrit-Change-Number: 14426 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Oct 2019 04:24:24 +0000 Gerrit-HasComments: Yes
