YangSong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 28: (4 comments) http://gerrit.cloudera.org:8080/#/c/14306/25/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14306/25/src/kudu/tools/kudu-tool-test.cc@5776 PS25, Line 5776: > nit: What enum is this referring to? The bound_type? Maybe be more specific Here include encoding type, compresssion type and range partition bound type. All defined as enum. http://gerrit.cloudera.org:8080/#/c/14306/25/src/kudu/tools/kudu-tool-test.cc@6424 PS25, Line 6424: > Isn't this also an error? Yes, encoding type is defined as a enum type. Here using a invalid string, error will be reported during parse the JSON to PB. http://gerrit.cloudera.org:8080/#/c/14306/25/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/25/src/kudu/tools/tool_action_table.cc@981 PS25, Line 981: type); > nit: which integer are you referring to? Do you mean if the column has no e No, here is the EncodingType define: enum EncodingType { AUTO_ENCODING = 0; PLAIN_ENCODING = 1; PREFIX_ENCODING = 2; RLE = 3; DICT_ENCODING = 4; BIT_SHUFFLE = 5; } The numbers 0 to 5 are correct, integer not in this range is unknown integer value. This place has a flaw, details are in the comments on PS 22. http://gerrit.cloudera.org:8080/#/c/14306/25/src/kudu/tools/tool_action_table.cc@984 PS25, Line 984: // converted to DEFAULT_COMPRESSION. I find here has a warning during building. The warning message is "warning: ‘type’ may be used uninitialized in this function". I initialize it at first, but in patch set 16 as the advice of Adar I removed it. Does this place need to remove this warning? -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 28 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 12:15:16 +0000 Gerrit-HasComments: Yes
