Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 31: (1 comment) http://gerrit.cloudera.org:8080/#/c/14306/29/src/kudu/tools/create-table-tool-test.cc File src/kudu/tools/create-table-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14306/29/src/kudu/tools/create-table-tool-test.cc@1237 PS29, Line 1237: > OK. One last thing. Could you revert the structure of the test so that it lays out the schema and validation in order, similar to how you did in PS25? Doing it this current way makes it difficult to understand this test. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 31 Gerrit-Owner: YangSong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2019 03:55:14 +0000 Gerrit-HasComments: Yes
