Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14533 )
Change subject: KUDU-2962 Fix kudu::itest::FindTabletFollowers() test utility function ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14533/3/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: http://gerrit.cloudera.org:8080/#/c/14533/3/src/kudu/integration-tests/cluster_itest_util.cc@699 PS3, Line 699: DCHECK(!tablet_peer_uuids.empty()); : // Sanity checking that tablet servers with the specified tablet are reporting : // the same leader and set of peers. : if (leader_uuid != cstate.leader_uuid()) { : return Status::IllegalState(Substitute( : "Leader $0 reported by tablet server $1 for tablet $2 doesn't match with leader $3 " : "reported by other tablet servers.", cstate.leader_uuid(), tablet_uuid, tablet_id, : leader_uuid)); > Perhaps I should make these return IllegalState error instead so that it's Done -- To view, visit http://gerrit.cloudera.org:8080/14533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94146873b09cb95c54175d16305b713365cfeaa8 Gerrit-Change-Number: 14533 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Oct 2019 22:14:44 +0000 Gerrit-HasComments: Yes
