Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14533 )

Change subject: KUDU-2962 Fix kudu::itest::FindTabletFollowers() test utility 
function
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14533/6/src/kudu/integration-tests/cluster_itest_util.cc
File src/kudu/integration-tests/cluster_itest_util.cc:

http://gerrit.cloudera.org:8080/#/c/14533/6/src/kudu/integration-tests/cluster_itest_util.cc@a649
PS6, Line 649:
             :
             :
             : 
             :
             :
             :
             :
             :
> Ack
Another option might be combining both FindTabletLeader() and 
FindTabletFollowers() into something like

  FindTabletReplicas(const TabletServerMap& tablet_servers, const string& 
tablet_id, const MonoDelta& timeout, TServerDetails* leader, 
vector<TServerDetails*>* followers);

where both output parameters are nullable.



--
To view, visit http://gerrit.cloudera.org:8080/14533
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94146873b09cb95c54175d16305b713365cfeaa8
Gerrit-Change-Number: 14533
Gerrit-PatchSet: 7
Gerrit-Owner: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Oct 2019 18:25:35 +0000
Gerrit-HasComments: Yes

Reply via email to