Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/14520/7/src/kudu/security/test/mini_kdc-test.cc File src/kudu/security/test/mini_kdc-test.cc: http://gerrit.cloudera.org:8080/#/c/14520/7/src/kudu/security/test/mini_kdc-test.cc@78 PS7, Line 78: // Test parse krb5 principal. : string principal = "kudu/[email protected]"; : string service_name; : string hostname; : string realm; : ASSERT_OK(security::Krb5ParseName(principal, &service_name, &hostname, &realm)); : ASSERT_EQ("kudu", service_name); : ASSERT_EQ("foo.example.com", hostname); : ASSERT_EQ("KRBTEST.COM", realm); > nit: I didn't notice it in the prior revision, but it would nice to join th Done http://gerrit.cloudera.org:8080/#/c/14520/7/src/kudu/security/test/mini_kdc-test.cc@90 PS7, Line 90: ASSERT_TRUE(security::Krb5ParseName("[email protected]", &service_name, &hostname, &realm).IsInvalidArgument()); > This line it too long: it's over 100 characters (LINT checks failed). You Done -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2019 17:46:42 +0000 Gerrit-HasComments: Yes
