Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14520 )
Change subject: KUDU-2979: Add wrapper function of krb5_parse_name to be used in Impala ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14520/4/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/14520/4/src/kudu/security/init.cc@466 PS4, Line 466: SCOPED_CLEANUP({ : krb5_free_principal(g_krb5_ctx, princ); : }); > If I clean up princ early, how can I get realm, service name, host name fro What the SCOPED_CLEANUP block is doing is saying "when I go out of scope, run this lambda". It's like if you had allocated memory use the new operator and then stored the result in a unique_ptr: the deallocation doesn't happen at the site of the unique_ptr declaration, it happens when the unique_ptr goes out of scope and is destroyed. -- To view, visit http://gerrit.cloudera.org:8080/14520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddafa7aae25d66ed7d9fa0306f17501a191cdac Gerrit-Change-Number: 14520 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2019 23:15:29 +0000 Gerrit-HasComments: Yes
