Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14570 )
Change subject: www: fix metrics.html ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14570/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14570/1//COMMIT_MSG@14 PS1, Line 14: Anyway, fixing it is easy enough, though I'm going to remove it in a : follow-on commit. > As much as we generally try to rely on thirdparty software, the histogram d /metrics.html has been broken since April 2015 when we introduced metric entities, so I don't think you can argue that it's been useful in the truest sense of the word. But since you're interested, I fixed up the /metrics handling so that now the histograms work too. Would you like me to drop the patch that removes /metrics.html? -- To view, visit http://gerrit.cloudera.org:8080/14570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I892febb19638724dcc6d2e278a38c0e8b23930e9 Gerrit-Change-Number: 14570 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Oct 2019 22:59:25 +0000 Gerrit-HasComments: Yes
