Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14570 )
Change subject: www: fix metrics.html ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14570/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14570/1//COMMIT_MSG@14 PS1, Line 14: Anyway, fixing it is easy enough, though I'm going to remove it in a : follow-on commit. > /metrics.html has been broken since April 2015 when we introduced metric en I'm not arguing that it has been useful -- I'm arguing it seems like it _can_ be useful, especially since the thirdparty tools I know don't do anything useful with our histogram metrics. Yeah, I'd prefer keeping the page around, if it doesn't get in the way of your other webserver work. That is, unless you have an argument for it not having much utility. -- To view, visit http://gerrit.cloudera.org:8080/14570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I892febb19638724dcc6d2e278a38c0e8b23930e9 Gerrit-Change-Number: 14570 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Oct 2019 23:04:28 +0000 Gerrit-HasComments: Yes
