Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14578
Change subject: [master] KUDU-2963 Fix and enhance TestCreateWhenMajorityOfReplicasFailCreation ...................................................................... [master] KUDU-2963 Fix and enhance TestCreateWhenMajorityOfReplicasFailCreation Commit d119d529 deflaked the test by wrapping the verification of tablets under ASSERT_EVENTUALLY. However crux of the problem was that test wasn't waiting for the table creation to complete which explains the flakiness observed. Despite fixing the bug, ASSERT_EVENTUALLY is still needed because there is a theoretical case of Delete Tablet RPCs still not being processed at the time of verification of the tablets. Instead of simply checking one tablet server, with this change checks are made across all the tablet servers. This change also adds verification such that once table creation is complete no further Create Tablet RPCs are issued/serviced. Tests: - Ran the test in a loop over 100 times. Change-Id: Id9943200dbf330481996e58e27744fe9fb49267f --- M src/kudu/integration-tests/create-table-itest.cc 1 file changed, 52 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/14578/1 -- To view, visit http://gerrit.cloudera.org:8080/14578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id9943200dbf330481996e58e27744fe9fb49267f Gerrit-Change-Number: 14578 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]>
