Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14578 )
Change subject: [master] KUDU-2963 Fix and enhance TestCreateWhenMajorityOfReplicasFailCreation ...................................................................... Patch Set 5: (4 comments) > Patch Set 4: Code-Review+2 > > (1 comment) http://gerrit.cloudera.org:8080/#/c/14578/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14578/4//COMMIT_MSG@27 PS4, Line 27: - Ran the test successfully in a loop over 1000 times using dist-test > BTW, you should use dist-test for this; you can loop a test 1000 times in j Done. http://gerrit.cloudera.org:8080/#/c/14578/3/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/14578/3/src/kudu/integration-tests/create-table-itest.cc@86 PS3, Line 86: urn itest::GetInt64Met > I think it's necessary to wrap every call to this function with NO_FATALS() Done http://gerrit.cloudera.org:8080/#/c/14578/3/src/kudu/integration-tests/create-table-itest.cc@144 PS3, Line 144: ASSERT_EVENTUALLY([&] { > Indeed. Ack http://gerrit.cloudera.org:8080/#/c/14578/3/src/kudu/integration-tests/create-table-itest.cc@145 PS3, Line 145: LOG(INFO) << "Waiting for the master to successfully create the table..."; : bool in_progress = true; : ASSERT_OK(client_->IsCreateTableInProgress(kTableName, &in_progress)); : ASSERT_FALSE(in_progress); : } > nit: this might be replaced with ASSERT_EVENTUALLY: Done -- To view, visit http://gerrit.cloudera.org:8080/14578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9943200dbf330481996e58e27744fe9fb49267f Gerrit-Change-Number: 14578 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 30 Oct 2019 22:43:15 +0000 Gerrit-HasComments: Yes
