Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14578 )
Change subject: [master] KUDU-2963 Fix and enhance TestCreateWhenMajorityOfReplicasFailCreation ...................................................................... [master] KUDU-2963 Fix and enhance TestCreateWhenMajorityOfReplicasFailCreation Commit d119d529 deflaked the test by wrapping the verification of tablets under ASSERT_EVENTUALLY. However crux of the problem was that test wasn't waiting for the table creation to complete which explains the flakiness observed. Despite fixing the bug, ASSERT_EVENTUALLY is still needed because there is a theoretical case of Delete Tablet RPCs still not being processed at the time of verification of the tablets. Instead of simply checking one tablet server, with this change checks are made across all the tablet servers. This change also adds verification such that once table creation is complete no further Create Tablet RPCs are issued/serviced. Tests: - Ran the test successfully in a loop over 1000 times using dist-test Change-Id: Id9943200dbf330481996e58e27744fe9fb49267f Reviewed-on: http://gerrit.cloudera.org:8080/14578 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/integration-tests/create-table-itest.cc 1 file changed, 64 insertions(+), 29 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9943200dbf330481996e58e27744fe9fb49267f Gerrit-Change-Number: 14578 Gerrit-PatchSet: 7 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
