Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14555 )
Change subject: KUDU-2977 Sharding block map to speed up tserver startup ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14555/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14555/3//COMMIT_MSG@15 PS3, Line 15: aquire acquire http://gerrit.cloudera.org:8080/#/c/14555/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/14555/1/src/kudu/fs/log_block_manager.cc@1861 PS1, Line 1861: static const uint64_t kBlockMapMask = kBlockMapChunk - 1; > No much significance. Server 1 has some other loaded processes on it, then BTW, the cache implementation (util/cache.cc) sets the number of shards to be equal to the number of CPUs on the machine. Did you look into doing that here? It's possible the number of shards you determined to be optimal is in fact optimal for the number of CPUs on the machines you tested, but may be less so on machines with more or fewer CPUs. -- To view, visit http://gerrit.cloudera.org:8080/14555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0d5c13e051a2c1d6cfd1c9ad7db8a3cd195459d Gerrit-Change-Number: 14555 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2019 22:04:20 +0000 Gerrit-HasComments: Yes
