Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14555 )

Change subject: KUDU-2977 Sharding block map to speed up tserver startup
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14555/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14555/3//COMMIT_MSG@15
PS3, Line 15: acquir
> acquire
Done


http://gerrit.cloudera.org:8080/#/c/14555/1/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:

http://gerrit.cloudera.org:8080/#/c/14555/1/src/kudu/fs/log_block_manager.cc@1861
PS1, Line 1861: static const uint64_t kBlockMapMask = kBlockMapChunk - 1;
> BTW, the cache implementation (util/cache.cc) sets the number of shards to
It's a good advice.
But in fact, one of the 2 machines I ran benchmark on has 32 CPU cores, the 
other has 24 CPU cores.



--
To view, visit http://gerrit.cloudera.org:8080/14555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0d5c13e051a2c1d6cfd1c9ad7db8a3cd195459d
Gerrit-Change-Number: 14555
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Sat, 02 Nov 2019 11:53:43 +0000
Gerrit-HasComments: Yes

Reply via email to