[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/8375/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8375/1//COMMIT_MSG@11 PS1, Line 11: - duration scanner was open in nanoseconds > Would it make sense to return two metrics based on the rpc's InboundCallTim I used the timing information from InboundCallTiming to add total_duration_nanos and wait_duration_nanos metrics for the rpc. http://gerrit.cloudera.org:8080/#/c/8375/4/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/8375/4/src/kudu/client/client-test.cc@457 PS4, Line 457: ASSERT_GT(metrics["cpu_system_nanos"], 0); I am not sure why this test is failing on jenkins. I added non pk column into the scan projects to see if that makes a difference. http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/scanners.h@424 PS3, Line 424: rpc::RemoteUser remote_user; > Nit: line too long, please wrap. In patch version 4, I used the timing information from InboundCallTiming, so I no longer have this code. http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/tablet_service.cc@702 PS3, Line 702: > Since context isn't being modified, pass it by cref. Done http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/tablet_service.cc@712 PS3, Line 712: trace->metrics()->GetMetric(SCANNER_BYTES_READ_METRIC_NAME)); > Line too long, please wrap. In patch version 4, I used the timing information from InboundCallTiming, so I no longer have this code. http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/tablet_service.cc@719 PS3, Line 719: > Nit: indent by one character. Done http://gerrit.cloudera.org:8080/#/c/8375/3/src/kudu/tserver/tablet_service.cc@720 PS3, Line 720: private: > warning: invalid case style for private member 'scan_rpc_metrics' [readabil Done -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 12 Nov 2019 01:58:00 +0000 Gerrit-HasComments: Yes
