Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8375 )
Change subject: KUDU-2162 Expose stats about scan filters ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/rpc/inbound_call.h File src/kudu/rpc/inbound_call.h: http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/rpc/inbound_call.h@62 PS7, Line 62: struct InboundCallTiming { Might be nice to DCHECK in each of the accessors that the MonoTimes you're operating on are initialized. http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/tserver/scanners.cc File src/kudu/tserver/scanners.cc: http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/tserver/scanners.cc@422 PS7, Line 422: descriptor.last_access_time = last_access_time_; : } : : descriptor.cpu_times = cpu_times(); Revert this chunk back to the way it was? Yeah you wouldn't be leveraging your new accessor, but seems undesirable to acquire lock_ twice to do so. http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/tserver/scanners.cc@431 PS7, Line 431: CpuTimes cpu_times; : { : std::lock_guard<simple_spinlock> l(lock_); : cpu_times = cpu_times_; : } : return cpu_times; Given how little this function does, would be simpler to write as: std::lock_guard<simple_spinlock> l(lock_); return cpu_times; http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: PS7: Rather than adding new plumbing to get cpu_times in and out of these functions, could we define it in the ScanResultCollector and piggy-back on that existing plumbing? http://gerrit.cloudera.org:8080/#/c/8375/7/src/kudu/tserver/tablet_service.cc@1613 PS7, Line 1613: void SetResourceMetrics(const rpc::RpcContext* context, Nit: we don't indent functions just because they're defined in namespaces. The original indentation here was more correct: no indentation because it's a top-level entity. -- To view, visit http://gerrit.cloudera.org:8080/8375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30a7e82357fe2fc28f6d316378a612af43d8c96 Gerrit-Change-Number: 8375 Gerrit-PatchSet: 7 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2019 07:10:08 +0000 Gerrit-HasComments: Yes
