Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14691 )
Change subject: WIP KUDU-2994: add NO_CHRONY flag ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/14691/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14691/1//COMMIT_MSG@9 PS1, Line 9: NO_CHONY NO_CHRONY http://gerrit.cloudera.org:8080/#/c/14691/1//COMMIT_MSG@20 PS1, Line 20: WIP: should we remove all the MiniChronyd as well if NO_CHRONY : is specified? I tried to do so, and it works but requires : added several #ifdefs into external_mini_cluster.{cc,h}. It's less important because MiniChrony is only loosely coupled with chrony itself, but I suppose it'd still be nice to do from a POLA perspective. http://gerrit.cloudera.org:8080/#/c/14691/1/build-support/mini-cluster/build_mini_cluster_binaries.sh File build-support/mini-cluster/build_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/14691/1/build-support/mini-cluster/build_mini_cluster_binaries.sh@110 PS1, Line 110: -DNO_TESTS=1 -DNO_CHRONY=1 \ Might want to expand on the comment on L104 to rationalize this. http://gerrit.cloudera.org:8080/#/c/14691/1/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/14691/1/src/kudu/mini-cluster/external_mini_cluster.cc@120 PS1, Line 120: num_ntp_servers(0) Do we want to allow using the built-in NTP client _without_ MiniChronyd? I don't think we'd ever want to build tests that way (need Internet access, slow to acquire sync, etc.) but could be an interesting option for `kudu test mini_cluster`. It's not in scope of this change though. -- To view, visit http://gerrit.cloudera.org:8080/14691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95495f8a2418546048e2ea28c4f44cb399f08fd3 Gerrit-Change-Number: 14691 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 06:11:09 +0000 Gerrit-HasComments: Yes
