Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14691 )
Change subject: KUDU-2994: add NO_CHRONY flag ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14691/2/src/kudu/clock/CMakeLists.txt File src/kudu/clock/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14691/2/src/kudu/clock/CMakeLists.txt@41 PS2, Line 41: # These are copied/installed instead of linking because: : # * symlinks would not work with dist-test : # * hardlinks would not work if the target directory is at different : # filesystem than thirdparty : file(COPY "${CMAKE_SOURCE_DIR}/thirdparty/installed/common/bin/chronyc" : DESTINATION "${EXECUTABLE_OUTPUT_PATH}") : file(COPY "${CMAKE_SOURCE_DIR}/thirdparty/installed/common/sbin/chronyd" : DESTINATION "${EXECUTABLE_OUTPUT_PATH}") > May as well revert this indentation, or indent all of L50-L64. Done http://gerrit.cloudera.org:8080/#/c/14691/2/src/kudu/clock/CMakeLists.txt@71 PS2, Line 71: if (NOT NO_CHRONY) > Nit: invert to avoid confusing double negative. Done -- To view, visit http://gerrit.cloudera.org:8080/14691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95495f8a2418546048e2ea28c4f44cb399f08fd3 Gerrit-Change-Number: 14691 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 08:32:50 +0000 Gerrit-HasComments: Yes
