Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG@9 PS2, Line 9: The one gotcha is that the symbolic links won't exist a priori > Why is it needed at all? I'm not sure I understand: as of now, tests invol Right, but I think symlinking the chrony binaries is cleaner. It's also more consistent with how we manage other thirdparty dependencies like this (e.g. Sentry and Hive bundles). -- To view, visit http://gerrit.cloudera.org:8080/14684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de Gerrit-Change-Number: 14684 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Nov 2019 21:23:34 +0000 Gerrit-HasComments: Yes
