Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14684 )
Change subject: mini_chronyd: switch to using symbolic links ...................................................................... Patch Set 2: Code-Review+2 (1 comment) It seems this patch needs to be rebased, but overall LGTM. http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14684/2//COMMIT_MSG@9 PS2, Line 9: The one gotcha is that the symbolic links won't exist a priori > Right, but I think symlinking the chrony binaries is cleaner. It's also mor I agree: symlinking is cleaner since that way there is no duplication of the same data on disk, at least. -- To view, visit http://gerrit.cloudera.org:8080/14684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id24d97d2badfee3e121f01a5280a2879513782de Gerrit-Change-Number: 14684 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Nov 2019 04:05:18 +0000 Gerrit-HasComments: Yes
