Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14445 )
Change subject: [tablet] Use std::deque instead of std::vector to collect blocks ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14445/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14445/1//COMMIT_MSG@9 PS1, Line 9: Container size may reallocate and elements will be copied several : times if use std::vector in TabletMetadata::CollectBlockIds and : associate functions, st > Yeah, but there are downsides to using std::list too: Done -- To view, visit http://gerrit.cloudera.org:8080/14445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ce853e35eb7dfa9f9a099e465ea8edfaa7c4aa9 Gerrit-Change-Number: 14445 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2019 03:40:27 +0000 Gerrit-HasComments: Yes
