Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14445 )
Change subject: [tablet] Use std::deque instead of std::vector to collect blocks ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/14445/3//COMMIT_MSG Commit Message: PS3: > Could you summarize your perf results into the commit message? Done http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc File src/kudu/tablet/tablet_metadata-test.cc: http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc@87 PS3, Line 87: : // Test that loading & storing the superblock results in an equivalent file. : TEST_F(TestTabletMetadata, TestLoadFromS > Couldn't you just reference tablet()->tablet_metadata() to get the already- Done http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc@100 PS3, Line 100: ASSERT_OK(writer_->Insert(*row)); > Nit: ASSERT_OK. Done http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc@102 PS3, Line 102: > Add a using for this. Done -- To view, visit http://gerrit.cloudera.org:8080/14445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ce853e35eb7dfa9f9a099e465ea8edfaa7c4aa9 Gerrit-Change-Number: 14445 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2019 15:18:10 +0000 Gerrit-HasComments: Yes
